Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatables v2.1 #801

Merged

Conversation

thomas-topway-it
Copy link
Contributor

Updated version of Datatables (v2) with the following improvements:

  • better accessibility (static table and spinners)
  • fixes search of multiple values
  • fixes navigation problem
  • implements searchBuilder
  • adds mark.js (with native parameters), integrates the following Highlight search results in new datatables format #776
  • fixes keyword datatype (with normalized values within the pane)
  • fixes template in printout not working with value containing pipe character
  • code better organized

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2023

Codecov Report

Attention: Patch coverage is 10.91270% with 449 lines in your changes are missing coverage. Please review.

Project coverage is 42.05%. Comparing base (c0dd4bb) to head (561e530).
Report is 3 commits behind head on master.

Files Patch % Lines
formats/datatables/SearchPanes.php 0.00% 382 Missing ⚠️
formats/datatables/Api.php 0.00% 58 Missing ⚠️
formats/datatables/DataTables.php 85.93% 9 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #801      +/-   ##
============================================
+ Coverage     40.12%   42.05%   +1.92%     
- Complexity     2332     2364      +32     
============================================
  Files            78       79       +1     
  Lines          8247     7719     -528     
============================================
- Hits           3309     3246      -63     
+ Misses         4938     4473     -465     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas-topway-it
Copy link
Contributor Author

thomas-topway-it commented Mar 26, 2024

@JeroenDeDauw and @gesinn-it-gea this now can be merged, can you check it ?

see here a demo with the SearchBuilder https://fina.knowledge.wiki/Catalogues_of_Numismatic_Collections

@JeroenDeDauw JeroenDeDauw merged commit 6dd7e46 into SemanticMediaWiki:master Mar 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants