Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore datatable filter responsive handling #824

Closed
wants to merge 1 commit into from

Conversation

alistair3149
Copy link
Contributor

The styles added by SRF was overriding the responsive media query rules set by datatables. This should restore the behavior.

The styles added by SRF was overriding the responsive media query rules set by datatables. This should restore the behavior.
@gesinn-it-gea
Copy link
Member

@krabina can you have a look at this PR

@krabina
Copy link
Contributor

krabina commented Mar 20, 2024

@thomas-topway-it can you check this, please?

@thomas-topway-it
Copy link
Contributor

I have tested it here https://fina.knowledge.wiki/Copies_or_Translations_of_Printed_Books

with the latest SemanticResultFormats and it looks fine.
The style restores the original datatables styling.

Also (this is unrelated to this issue) is there a specific reason for the existence of this repository
https://github.com/semanticMediaWiki/SemanticresultFormats

"result" lowercase ?

@thomas-topway-it
Copy link
Contributor

however, I've tested again with this version
https://github.com/Knowledge-Wiki/SemanticResultFormats/tree/datatables-v2-improvements
(rebased from SemanticResultFormats master)
and the styling issue does not show also without the patch

@krabina
Copy link
Contributor

krabina commented May 4, 2024

@alistair3149 can you confirm that the desired behavior is there in current master and we can ignore this?

@alistair3149
Copy link
Contributor Author

Yes it is fixed now, closing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants