Replace Language::factory #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to support older method. Since SRF 4.0.x (now obsolete), the minimum version is MW 1.35.
No need to support wfFindFile (MW 1.33 or older). SRF's minimum version is MW 1.34.
whitespace
Replace Language::factory, which has been deprecated since 1.35 (removed by 1.41).
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #839 +/- ##
============================================
+ Coverage 40.12% 40.79% +0.66%
- Complexity 2332 2404 +72
============================================
Files 78 81 +3
Lines 8247 7852 -395
============================================
- Hits 3309 3203 -106
+ Misses 4938 4649 -289 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace Language::factory, which has been deprecated since MW 1.35 and was removed by MW 1.41. (Ignore the 'null-ish' commits)