Added weaver completion bash completion command.
#385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a `weaver completion` command that spits out a bash completion script that enables tab completion for the weaver command. For example: ```bash $ weaver <tab><tab> generate gke gke-local multi single ssh version $ weaver single <tab><tab> dashboard deploy help metrics profile purge status version $ weaver single p<tab><tab> profile purge ``` To enable the tab completion, you run `source <(weaver completion)`. This mirrors [`kubectl completion bash`][3]. Source the file in your ~/.bashrc if you always want it to be enabled. I added `weaver completion` selfishly, as I thought it was useful. If others find it useful, we can advertise it to users. [3]: https://kubernetes.io/docs/reference/kubectl/cheatsheet/#kubectl-autocomplete
mwhittaker
force-pushed
the
bash_completion
branch
from
00131fc
to
acb2081
Compare
spetrovic77
approved these changes
Jun 12, 2023
| subcommands["single"]="dashboard deploy help metrics profile purge status version" | ||
| subcommands["multi"]="dashboard deploy help logs metrics profile purge status version" | ||
| subcommands["ssh"]="dashboard deploy help logs version" | ||
| subcommands["gke"]="dashboard deploy help kill logs profile status version" |
There was a problem hiding this comment.
This is really nice, Michael!
Is there any way to defer to weaver-gke and weaver-gke-local executables for completion on those? This will also help with other deployer commands.
There was a problem hiding this comment.
Thanks! Oh great point. Let me do some research into that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
weaver completioncommand that spits out a bash completion script that enables tab completion for the weaver command. For example:To enable the tab completion, you run
source <(weaver completion). This mirrorskubectl completion bash. Source the file in your~/.bashrcif you always want it to be enabled.I added
weaver completionselfishly, as I thought it was useful. If others find it useful, we can advertise it to users. There is a bit of overhead in updating it whenever commands change, and the gke commands could be stale, so it would require work to be more robust. Also happy to leave this out of the repo and have it privately for myself.