Remove NonNegativeBuckets #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NonNegativeBuckets were used for our generated metrics. However, it is in the public metrics package, and users can rely on it to define their histograms. However, NonNegativeBuckets has a huge number of buckets which lead to large data for the metrics. The users have complained that our buckets are too fine-grained and the cost to export the metrics is quite high. This PR removes the NonNegativeBuckets and forces the user to define their own buckets for their histograms.
spetrovic77
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NonNegativeBuckets were used for our generated metrics. However, it is in the public metrics package, and users can rely on it to define their histograms.
However, NonNegativeBuckets has a huge number of buckets which lead to large data for the metrics. The users have complained that our buckets are too fine-grained and the cost to export the metrics is quite high.
This PR removes the NonNegativeBuckets and forces the user to define their own buckets for their histograms.