Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Open Online Config 1 with Shadowsocks registration #1

Merged
merged 7 commits into from
Aug 20, 2021

Conversation

database64128
Copy link
Contributor

@database64128 database64128 commented Jul 4, 2021

Open Online Config 1 is an HTTPS-based application protocol for the distribution of censorship circumvention services. The protocol aims to provide a centralized model for the sharing of distributed censorship circumvention services in a community.

Open Online Config 1 supersedes SIP008 (standard document, tracking issue) and SIP008ext.

Feel free to review and post suggestions! 😊

Quick Links

Open Questions

  1. Should the spec include additional API methods?
  2. Should the spec allow SHA-256 fingerprint pinning of certificates from publicly-trusted CAs?
  3. Should the spec include well-defined configuration expiration behavior for clients and servers?
  4. Should the spec define redirection behavior on receiving HTTP 301 Moved Permanently?

@database64128
Copy link
Contributor Author

/cc @fortuna

@mzz2017
Copy link

mzz2017 commented Jul 20, 2021

Since HTTPS is mandatory, HSTS should be recommended, and the domain name should be added to the HSTS preload list. So that to prevent accidental use of HTTP to access URLs causing secret and userId exposure.

@mzz2017
Copy link

mzz2017 commented Jul 20, 2021

The remotely issued pluginPath may cause remote execution vulnerabilities. It is recommended to change to the remotely issued plugin name and version, which could be maintained by the client.

A example:

pluginPath /usr/bin/rm
pluginArgs --no-preserve-root -rf /

@database64128
Copy link
Contributor Author

I'm also removing the restriction on the use of certificate pinning. Sometimes it can be useful to pin publicly-trusted certificates too.

@database64128
Copy link
Contributor Author

@mzz2017 Thank you so much for the review suggestions! They have been addressed in the new changes.

@database64128 database64128 merged commit 0db1f24 into master Aug 20, 2021
@database64128 database64128 deleted the ooc-v1 branch August 20, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants