ENH: support multiple scattering planes for KF #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidLP
requested changes
Jun 19, 2017
testbeam_analysis/track_analysis.py
Outdated
| z_scatter: z position of scattering plane in um | ||
| material_budget_scatter: material budget of scattering plane | ||
| alignment_scatter: list which contains alpha, beta and gamma angles of scattering plane. | ||
| If None, no rotation will be considered. | ||
| In case of multiple scattering planes, each value of a key is a list, with items corresponding to each scatterong plane. |
testbeam_analysis/track_analysis.py
Outdated
| z_scatter: z position of scattering plane in um | ||
| material_budget_scatter: material budget of scattering plane | ||
| alignment_scatter: list which contains alpha, beta and gamma angles of scattering plane. | ||
| If None, no rotation will be considered. | ||
| In case of multiple scattering planes, each value of a key is a list, with items corresponding to each scatterong plane. | ||
| If whole dict is False, no scattering plane will be added. |
There was a problem hiding this comment.
If add_scattering_plane is false
| dut_fit_selection[np.where(dut_fit_selection > (index_scatter - 1))[0][0]:] = dut_fit_selection[np.where(dut_fit_selection > (index_scatter - 1))[0][0]:] + 1 | ||
| if add_scattering_plane: | ||
| for i in range(len(index_scatter)): # need to shift dut fit selection in case of additional scattering plane | ||
| dut_fit_selection[np.where(dut_fit_selection > (index_scatter[i] - 1))[0][0]:] = dut_fit_selection[np.where(dut_fit_selection > (index_scatter[i] - 1))[0][0]:] + 1 |
There was a problem hiding this comment.
Since a scattering plane is no DUT I wonder why dut_fit_selection is changed.
There was a problem hiding this comment.
This has also to be changed, since the dut_index is different if additional scattering planes are considered. E.g. if we want to use DUT 0 and 1 in fit, and add a scattering plane in between, the dut_indices are now: 0, 1 (scattering plane) and 2. Then dut_fit_selection has to be changed to dut_fit_selection = [0, 2] .
DavidLP
approved these changes
Jun 30, 2017
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to requested changes for additional scattering plane option for KF
ENH:
MAINT:
change default case from
NonetoFalseremove redundant
index_scatter