Exit code != 0 on error

SigmaHQ · May 15, 2024 · 8af66de · 8af66de
1 parent 5d5c010
commit 8af66de
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/sigma/cli/check.py b/sigma/cli/check.py
@@ -253,4 +253,4 @@ def check(
             click.echo("Check failure")
             click.get_current_context().exit(1)
     except SigmaError as e:
-        click.echo("Check error: " + str(e), err=True)
+        raise click.ClickException("Check error: " + str(e))
diff --git a/sigma/cli/convert.py b/sigma/cli/convert.py
@@ -311,15 +311,15 @@ def convert(
         elif isinstance(result, dict):
             click.echo(bytes(json.dumps(result, indent=json_indent), encoding))
         else:
-            click.echo(
-                f"Backend returned unexpected format {str(type(result))}", err=True
+            raise click.ClickException(
+                f"Backend returned unexpected format {str(type(result))}"
             )
     except SigmaError as e:
-        click.echo("Error while conversion: " + str(e), err=True)
+        raise click.ClickException("Error while conversion: " + str(e))
     except NotImplementedError as e:
-        click.echo("Feature required for conversion of Sigma rule is not supported by backend: " + str(e), err=True)
+        raise click.ClickException("Feature required for conversion of Sigma rule is not supported by backend: " + str(e))
 
     if len(backend.errors) > 0:
         click.echo("\nIgnored errors:", err=True)
         for rule, error in backend.errors:
-            click.echo(f"{str(rule.source)}: {str(error)}", err=True)
+            raise click.ClickException(f"{str(rule.source)}: {str(error)}")