Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark FormatMojo as threadSafe because it is thread-safe #216

Merged
merged 1 commit into from
May 14, 2023

Conversation

ksumit
Copy link
Contributor

@ksumit ksumit commented Jul 8, 2022

Description

This will help avoid warning messages like one reported in #215 for multi-threaded maven builds

Fixes # 215

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Not tested, this is a straight forward change. A similar change exists here

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

This will help avoid warning messages like one reported in SimonJPegg#215
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

PR appears to be stale

@timw
Copy link

timw commented May 12, 2023

@SimonJPegg - how do you feel about merging this and dropping a new release?
We can continue ignoring the warning, but it'd be nice to tidy up.

@SimonJPegg SimonJPegg reopened this May 14, 2023
@SimonJPegg SimonJPegg merged commit 9f83818 into SimonJPegg:master May 14, 2023
4 checks passed
@timw
Copy link

timw commented May 15, 2023

Nice one. Thanks :)
Now we just need a good reason to drop a release...

@ksumit ksumit deleted the patch-1 branch May 16, 2023 16:24
@pan3793
Copy link

pan3793 commented Apr 11, 2024

2.12-1.1.1684076452.9f83818 this release is missed on Maven Central, could you please fix it? @SimonJPegg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants