Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kafka reporter #596

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lu-xiaoshuang
Copy link
Contributor

@lu-xiaoshuang lu-xiaoshuang commented Jun 25, 2024

Please answer these questions before submitting pull request

  • Why submit this pull request?
    New feature provided

  • How to test?
    grpc server: set ASPNETCORE_ENVIRONMENT=Development && set ASPNETCORE_HOSTINGSTARTUPASSEMBLIES=SkyAPM.Agent.AspNetCore && sample\grpc\SkyApm.Sample.GrpcServer\bin\Release\net6.0\SkyApm.Sample.GrpcServer.exe
    grpc client: set ASPNETCORE_ENVIRONMENT=Development && set ASPNETCORE_HOSTINGSTARTUPASSEMBLIES=SkyAPM.Agent.AspNetCore && sample\grpc\SkyApm.Sample.GrpcClient\bin\Release\net6.0\SkyApm.Sample.GrpcClient.exe

SEE ALSO #559

@wu-sheng wu-sheng added this to the 2.3.0 milestone Jun 25, 2024
@wu-sheng
Copy link
Member

Please fix CI.

@wu-sheng wu-sheng requested a review from liuhaoyang June 25, 2024 10:53
@lu-xiaoshuang
Copy link
Contributor Author

Hi @liuhaoyang & @wu-sheng, shall we merge this pull request to main branch?

@wu-sheng
Copy link
Member

@liuhaoyang needs to review this first. I would not merge any function relative PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants