-
Notifications
You must be signed in to change notification settings - Fork 33
Conversation
Take a reference about how to do plugin e2e testing.
@mrproliu We really need skywalking-infra-e2e doc ready and get to release ASAP. |
OK. I'll start it in this weekend. |
@arugal Please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
const ( | ||
componentIDGoKratosServer = 5010 | ||
componentIDGoKratosClient = 5011 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kagaya85 The componentID
need to be define in the component-libraries.yml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kagaya85 Let's merge these two, and you could pick one component ID.
add a plugin for go-kratos framework