feat: add dubbo-go plugins #34
Conversation
Co-authored-by: zhang-wei <[email protected]>
Co-authored-by: zhang-wei <[email protected]>
Co-authored-by: zhang-wei <[email protected]>
Co-authored-by: zhang-wei <[email protected]>
Co-authored-by: zhang-wei <[email protected]>
dubbo-go/README.md
Outdated
| log.Fatalf("set tracer error: %v \n", err) | ||
| } | ||
| // set extra tags and report tags | ||
| dubbo_go.SetClientExtraTags("extra-tags", "server") |
There was a problem hiding this comment.
@royal-dargon The server should use SetServerExtraTags and SetServerReportTags, right?
|
@royal-dargon Please add dubbo-go here. |
There was a problem hiding this comment.
@royal-dargon Basically no problem, please commit suggestions, and set PR to ready review.
|
After PR merged, the component id and Component-Server-Mappings of |
Co-authored-by: zhang-wei <[email protected]>
Co-authored-by: zhang-wei <[email protected]>
Co-authored-by: zhang-wei <[email protected]>
As dubbo-go belongs to dubbo, how about using Dubbo's component id? |
dubbo-go/test/expected.data.yml
Outdated
| {{- range .segmentItems }} | ||
| {{- if eq .serviceName "dubbo-go-server" }} |
There was a problem hiding this comment.
Notice, take a look at this context, apache/skywalking#7849 (comment).
range should not be used in the expected file.
@arugal You also should update the existing cases.
dubbo-go/dubbo-go.go
Outdated
| componentIDGo2SkyClient = 5013 | ||
| componentIDGo2SkyServer = 5014 |
There was a problem hiding this comment.
Take a look at this, https://github.com/apache/skywalking/blob/ebd040eb1a3ed92e79da6f917cb9c9fe44a6938d/oap-server/server-starter/src/main/resources/component-libraries.yml#L41-L43.
You don't need client and server, also, you don't need new component IDs. You could update languages field in the YAML of main repo.
There was a problem hiding this comment.
Mapping is for indicating a server side which is not tracing. Such as MySQL JDBC driver to MySQL server. For MySQL server, we don't expect an agent installed.
Add dubbo-go plugins.
Add test files.