supported dubbo-go v3.0.2 #49
Conversation
curl -L https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s v1.45.2 -> curl -L https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.45.2 |
| if attachment, ok := invocation.GetAttachment(key); ok { | ||
| return attachment, nil | ||
| } | ||
| return "", nil |
There was a problem hiding this comment.
This looks like an API change of invocation. Does this mean a breaking change originally from dubbo-go project?
There was a problem hiding this comment.
What is the current dubbo-go version?
There was a problem hiding this comment.
OK, so move from RC to GA release.
There was a problem hiding this comment.
So, what should I do for the next?
There was a problem hiding this comment.
What is the current dubbo-go version?
v3.0.3. the old version 3.0.0-rc2 is out of time now.
Yes |
|
@dgqypl thank you for your great work. pls attention that the current dubbogo version is v3.0.2, pls upgrade dubbogo version to the latest version. thank you. |
I'll upgrade that tomorrow 😴. |
already up to date |
|
@dgqypl Also need to look at why golang-lint fails, are you interested? I was successful on go 1.18.3, which is probably related to the golang version |
Please change this pr's title, thx. |
Actually, I don't know how to do right now, can you give me some tips, thx. |
changed |
as a basic lib, the old version is perfect for many users. the older, the better. |
|
Dubbo go case seems running on go 1.14. Is 14 still working for this latest Dubbo version? |
|
Take a look at the GitHub control file. |
|
I mean CI control file, I am not sure which part controls env initialization. |
|
https://github.com/SkyAPM/go2sky-plugins/blob/master/.github/workflows/ci.yaml#L42 @dgqypl Please change the golang version here to 1.15 |
|
https://github.com/SkyAPM/go2sky-plugins/runs/7260518151?check_suite_focus=true E2E test also failed, please check |
ok, I'll modify later. |
right now left only this fails, how can I fix it? |
https://github.com/SkyAPM/go2sky-plugins/runs/7264192077?check_suite_focus=true#step:4:248 e2e logs show that the connection between dubbo-go and zookeeper is abnormal |
|
@dgqypl Could you fix the test? |
I had already fix it right now. |
|
from the latest container log, it shows: I really don't know how to fix it. Is there anyone who can directly tell me how to do. |
|
This seems a dubbo go error? I think it is better to ask them. |
|
@AlexStocks can you help me to fix it? thx |
how should i contact you |
Pls join the dingding group 23331795 and contact with this group owner yuyu[me] and then let's have a discussion with @zhaoyunxing92 . |
# Conflicts: # dubbo-go/test/client/conf/client.yml
|
I had already fix CI error associated with dubbogo, so the only thing left is CI error with expected.data.yml, I don't know how to modify this file and let the CI passed, anybody can help me to resolve this problem? |
|
This is an e2e test framework go2sky is using. This section is about the expected file, https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/plugin-test/#expecteddatayaml Generally, it is about what the traces you collected should be |
|
I think you forgot to revert GHA file changes. |
|
The latest commit is reverted , please try again the workflows, I'm tested CI passed in my forked repository. |
|
@arugal @AlexStocks Please take a look. |
No description provided.