Added FancyNpcs integration #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added FancyNpcs integration
|
Whilst I still haven't tested this exact jar I have made an addon jar that is working with the same code (Hence the fixes) |
SkytAsul
requested changes
Aug 4, 2024
integrations/src/main/java/fr/skytasul/quests/integrations/npcs/BQFancyNPCs.java
Show resolved
Hide resolved
integrations/src/main/java/fr/skytasul/quests/integrations/npcs/BQFancyNPCs.java
Outdated
Show resolved
Hide resolved
integrations/src/main/java/fr/skytasul/quests/integrations/npcs/BQFancyNPCs.java
Show resolved
Hide resolved
|
Seems good! I have compiled a version of BeautyQuests with this fix included, may I send it to you on Discord so you can test it? |
SkytAsul
approved these changes
Aug 9, 2024
|
Sure, my discord is |
|
I can't add you as a friend, your requests are closed 😅 can you add me (@SkytAsul) or come on my Discord server? |
|
Ahh, I'll join your Discord |
|
Is there anything else that needs doing regarding this one? |
|
Nah it's completely fine, I'll merge soon. |
|
Thank you very much for the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't been able to test this because I don't have all of the dependencies maven installed. If there is anything immediately obvious that is missing please let me know.
Also if someone would be able to compile this PR for me to test that'd be wonderful :)