-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added FancyNpcs integration #331
Conversation
Added FancyNpcs integration
Whilst I still haven't tested this exact jar I have made an addon jar that is working with the same code (Hence the fixes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the small change and the questions I asked, it seems really good! I'll compile and test it asap.
integrations/src/main/java/fr/skytasul/quests/integrations/npcs/BQFancyNPCs.java
Show resolved
Hide resolved
integrations/src/main/java/fr/skytasul/quests/integrations/npcs/BQFancyNPCs.java
Outdated
Show resolved
Hide resolved
integrations/src/main/java/fr/skytasul/quests/integrations/npcs/BQFancyNPCs.java
Show resolved
Hide resolved
Seems good! I have compiled a version of BeautyQuests with this fix included, may I send it to you on Discord so you can test it? |
Sure, my discord is |
I can't add you as a friend, your requests are closed 😅 can you add me (@SkytAsul) or come on my Discord server? |
Ahh, I'll join your Discord |
Is there anything else that needs doing regarding this one? |
Nah it's completely fine, I'll merge soon. |
Thank you very much for the PR :) |
I haven't been able to test this because I don't have all of the dependencies maven installed. If there is anything immediately obvious that is missing please let me know.
Also if someone would be able to compile this PR for me to test that'd be wonderful :)