add api wrapper with retries (WP-669) #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+693
to
+696
| private function formatError(\Exception $e): string | ||
| { | ||
| return $e instanceof SmartlingApiException ? $e->formatErrors() : $e->getMessage(); | ||
| } |
There was a problem hiding this comment.
Extracted helper function since \Exception doesn't have formatErrors()
PavelLoparev
approved these changes
Dec 29, 2021
dimitrystd
approved these changes
Jan 3, 2022
| use Smartling\Vendor\Jralph\Retry\Retry; | ||
| use Smartling\Vendor\Jralph\Retry\RetryException; | ||
|
|
||
| class ApiWrapperWithRetries implements ApiWrapperInterface { |
There was a problem hiding this comment.
I think I already left this comment: why not use PHP magic methods instead of implement dumb proxy for each method
There was a problem hiding this comment.
I'm a strong opponent of magic methods, but I've tried experimenting with them for this task. I've found no magic methods that are applicable, so created another wrapper level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.