Fix issue with _compute_qty not passing correct parameter reference #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_compute_qty_obj was changed to add parameter "rounding_method" (default UP) to _compute_qty_obj. _compute_qty though was not modified for this change and does not pass parameter names as references to _compute_qty_obj, therefor causing an error when modifying quantities on sale.order.line. Fix is to simply reference context=context so that the default value of rounding_method is selected.
smile-odoo-gu
approved these changes
Oct 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_compute_qty_obj was changed to add parameter "rounding_method" (default UP) to _compute_qty_obj.
_compute_qty though was not modified for this change and does not pass parameter names as references to _compute_qty_obj, therefor causing an error when modifying quantities on sale.order.line.
Fix is to simply reference context=context so that the default value of rounding_method is selected.