Lazy property bug fix #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re-declaring the lazy property is not always working depending on when in the startup chain the call to get the session store is used. This can be before the lazy property is re-declared. However this can be directly set on the singleton property and this results in proper functionality. However we loose lazy loading. This however is not a problem because the session store will definitely always be required, so the lazy loading is not providing anything for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-declaring the lazy property is not always working depending on when in the startup chain the call to get the session store is used. This can be before the lazy property is re-declared. However this can be directly set on the singleton property and this results in proper functionality. However we loose lazy loading. This however is not a problem because the session store will definitely always be required, so the lazy loading is not providing anything for us.