Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Experimental implementation for compiling email templates (usage from foundation for emails) #338

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Commits on Nov 6, 2018

  1. Configuration menu
    Copy the full SHA
    59bb2cd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2f80beb View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2018

  1. Configuration menu
    Copy the full SHA
    b9de177 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aeb43fc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b388d2e View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2018

  1. Configuration menu
    Copy the full SHA
    1b4ae09 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9a668bb View commit details
    Browse the repository at this point in the history
  3. Fix indention

    marvinhuebner committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    741d6d3 View commit details
    Browse the repository at this point in the history
  4. Fix tests

    marvinhuebner committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    8549b9e View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2018

  1. Add regex for replacing '{!!' and '!!}' after compiling handlebars te…

    …mplates
    
    Since handlebars also uses curly braces and the raw helper is often a bit awkward, a new template helper ({!! and !!}) is introduced, which gets replaced after handlebars is compiled  to the curly braces to be interpreted by magento.
    marvinhuebner committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    ec2219c View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2018

  1. Patch panini to make sure that the options are always applied

    Otherwise it would take only the options which are passed then creating the instance. But due the fact that there is the possibility to overwrite these files, it has to take the path from the current theme which gets compiled.
    marvinhuebner committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    bf0b7d5 View commit details
    Browse the repository at this point in the history
  2. Enhance watcher and run not the complete sequence, rather only we par…

    …ts which should be updated
    marvinhuebner committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    6c126e9 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2018

  1. Instantiate a new panini instance in each gulp task and patch panini …

    …to refresh the partials in all renderers
    
    Panini exports an singleton, through that it holds all options and they can not be overwritten. This change adds a new panini instance for each task to hold it's own options.
    
    Panini is patched because Handlebars is also a singleton, so the partials will be overwritten. You can find more infos here: foundation/panini#81 (comment)
    marvinhuebner committed Nov 16, 2018
    Configuration menu
    Copy the full SHA
    9f182e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2018

  1. Fix tests

    marvinhuebner committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    1f700c3 View commit details
    Browse the repository at this point in the history