Notification2.0 and refactoring #198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reey
reviewed
Jun 4, 2024
Comment on lines
+22
to
+23
| "http-auth": "src/nodes/http-auth/http-auth.js", | ||
| "check-roles": "src/nodes/check-roles/check-roles.js" |
There was a problem hiding this comment.
removing the c8y- prefix will break functionality for existing microservice users, same for the realtime nodes..
There was a problem hiding this comment.
Yes, I know, but how many prod users do we have? Lets have a call.
node-red-contrib-c8y-client/src/nodes/notification/notification.js
Outdated
Show resolved
Hide resolved
node-red-contrib-c8y-client/src/nodes/notification/notification.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
In case a persistent subscription is created, you would need to also handle the deletion of that subscription whenever the node is removed.
There was a problem hiding this comment.
I dont know about that. Maybe the user wants to keep the messages in the queue....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will introduce: