Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AutoScroll plugin ignores scroll options #1580

Closed
andrewcourtice opened this issue Jul 19, 2019 · 3 comments
Closed

AutoScroll plugin ignores scroll options #1580

andrewcourtice opened this issue Jul 19, 2019 · 3 comments

Comments

@andrewcourtice
Copy link

andrewcourtice commented Jul 19, 2019 •
edited
Loading

Problem:

The autoscroll plugin appears to ignore the scroll options provided in the Sortable constructor and use the defaults.

JSBin/JSFiddle demonstrating the problem:

https://jsfiddle.net/s50fq8po/1/

Note the provided scrollSensitivity (128px) compared to the options (30px) at the breakpoint in the screenshot shown below:

Screen Shot 2019-07-19 at 10 37 10 am
owen-m1 added a commit that referenced this issue Jul 19, 2019
@owen-m1
#1580: Fix plugins' references to options
a8836d5
@owen-m1
Copy link
Member

owen-m1 commented Jul 19, 2019

Thanks for pointing this out, it should be solved in a8836d5.

@andrewcourtice
Copy link
Author

That's great! Thanks for looking into it so quickly.

@owen-m1 owen-m1 closed this as completed Jul 19, 2019
TimLuo465 added a commit to TimLuo465/Sortable that referenced this issue Aug 7, 2019
@TimLuo465
SortableJS#1580: Fix plugins' references to options
79a6221
@snyk-bot snyk-bot mentioned this issue Sep 24, 2019
Open
elo7-developer pushed a commit to elo7/Sortable that referenced this issue Nov 18, 2019
@owen-m1 @elo7-developer
SortableJS#1580: Fix plugins' references to options
9b4bcf0
@snyk-bot snyk-bot mentioned this issue Dec 5, 2019
Open
@snyk-bot snyk-bot mentioned this issue Mar 17, 2020
Open
@snyk-bot snyk-bot mentioned this issue Mar 25, 2020
Merged
@developerruhul
Copy link

it still isn't fixed. live example https://codesandbox.io/s/vanilla-sortablejs-scroll-gnnhb?file=/src/App.js

Runi-c pushed a commit to Tupperbox/Sortable that referenced this issue Nov 10, 2023
@owen-m1
SortableJS#1580: Fix plugins' references to options
41990c6
@snyk-io snyk-io bot mentioned this issue May 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewcourtice @owen-m1 @developerruhul