Prevent ignored touches on Android Chrome. #2095
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android Crhome will not trigger a click event if a user drags an item, even if the item is dropped back into its original placement. This means that whenever the "ignore next click" handling is activated, the user's _next_ click (unrelated to dragging) will be ignored. This commit solves this by never activating the "ignore next click" handling on Android Chrome.
itsjohncs
added a commit
to itsjohncs/thelounge
that referenced
this pull request
Oct 30, 2021
This is a (hopefully) temporary solution while we wait for SortableJS to merge in SortableJS/Sortable#2095 and make a release.
itsjohncs
added a commit
to itsjohncs/thelounge
that referenced
this pull request
Oct 30, 2021
This is a (hopefully) temporary solution while we wait for SortableJS to merge in SortableJS/Sortable#2095 and make a release.
itsjohncs
added a commit
to itsjohncs/thelounge
that referenced
this pull request
Oct 30, 2021
This is a (hopefully) temporary solution while we wait for SortableJS to merge in SortableJS/Sortable#2095 and make a release.
itsjohncs
added a commit
to itsjohncs/thelounge
that referenced
this pull request
Oct 30, 2021
This is a (hopefully) temporary solution while we wait for SortableJS to merge in SortableJS/Sortable#2095 and make a release.
|
@owen-m1 any chance of this being merged? We at github.com/thelounge/thelounge are waiting on this |
itsjohncs
added a commit
to itsjohncs/thelounge
that referenced
this pull request
Apr 18, 2022
SortableJS/Sortable#2095 has been merged so we no longer need to use our fork.
itsjohncs
added a commit
to itsjohncs/thelounge
that referenced
this pull request
Apr 18, 2022
SortableJS/Sortable#2095 has been merged so we no longer need to use our fork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android Chrome will not trigger a click event if a user drags an item,
even if the item is dropped back into its original placement. This
means that whenever the "ignore next click" handling is activated, the
user's next click (unrelated to dragging) will be ignored.
This commit solves this by never activating the "ignore next click"
handling on Android Chrome.