drop dmgbuild

SoulMelody · May 16, 2024 · 6d8b7cd · 6d8b7cd
1 parent 35b3ac9
commit 6d8b7cd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 128 deletions.
diff --git a/.github/workflows/package.yml b/.github/workflows/package.yml
@@ -226,14 +226,16 @@ jobs:
           source .venv/bin/activate
           cd packaging
           python -m ensurepip --upgrade
-          python -m pip install dmgbuild pillow uv
+          python -m pip install pillow uv
           python -m uv pip install -r requirements.txt
           cd ..
           pdm build --no-sdist
           python -m pip install dist/*.whl --no-deps
           cd packaging
           python -m PyInstaller libresvip.spec
-          python -m dmgbuild -s dmg_settings.py -D app=dist/LibreSVIP.app "LibreSVIP" dist/LibreSVIP-${{ needs.make-outputs.outputs.VERSION }}.macos-x86_64.dmg
+          brew install create-dmg
+          create-dmg --volname "LibreSVIP" dist/LibreSVIP-${{ needs.make-outputs.outputs.VERSION }}.macos-x86_64.dmg ./dist/LibreSVIP.app
+          rm -rf ./dist/LibreSVIP.app
           cd ..
       - name: Upload build artifact
         uses: actions/upload-artifact@v4
@@ -267,15 +269,17 @@ jobs:
           source .venv/bin/activate
           cd packaging
           python -m ensurepip --upgrade
-          python -m pip install dmgbuild pillow uv
+          python -m pip install pillow uv
           python -m uv pip install -r requirements.txt
           python download_libmediainfo.py
           cd ..
           pdm build --no-sdist
           python -m pip install dist/*.whl --no-deps
           cd packaging
           python -m PyInstaller libresvip.spec
-          python -m dmgbuild -s dmg_settings.py -D app=dist/LibreSVIP.app "LibreSVIP" dist/LibreSVIP-${{ needs.make-outputs.outputs.VERSION }}.macos-arm64.dmg
+          brew install create-dmg
+          create-dmg --volname "LibreSVIP" dist/LibreSVIP-${{ needs.make-outputs.outputs.VERSION }}.macos-arm64.dmg ./dist/LibreSVIP.app
+          rm -rf ./dist/LibreSVIP.app
           cd ..
       - name: Upload build artifact
         uses: actions/upload-artifact@v4

diff --git a/packaging/dmg_settings.py b/packaging/dmg_settings.py