UI: Fixed crash when connection error occurs when checking for updates

SourMesen · May 8, 2023 · da0825a · da0825a
1 parent 4c603ca
commit da0825a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/UI/ViewModels/MainMenuViewModel.cs b/UI/ViewModels/MainMenuViewModel.cs
@@ -1052,7 +1052,7 @@ private void InitHelpMenu(Window wnd)
 		public void CheckForUpdate(Window mainWindow, bool silent)
 		{
 			Task.Run(async () => {
-				UpdatePromptViewModel? updateInfo = await UpdatePromptViewModel.GetUpdateInformation();
+				UpdatePromptViewModel? updateInfo = await UpdatePromptViewModel.GetUpdateInformation(silent);
 				if(updateInfo == null) {
 					if(!silent) {
 						Dispatcher.UIThread.Post(() => {

diff --git a/UI/ViewModels/UpdatePromptViewModel.cs b/UI/ViewModels/UpdatePromptViewModel.cs
@@ -34,7 +34,7 @@ public UpdatePromptViewModel(UpdateInfo updateInfo)
 			_updateInfo = updateInfo;
 		}
 
-		public static async Task<UpdatePromptViewModel?> GetUpdateInformation()
+		public static async Task<UpdatePromptViewModel?> GetUpdateInformation(bool silent)
 		{
 			UpdateInfo? updateInfo = null;
 			try {
@@ -58,7 +58,11 @@ public UpdatePromptViewModel(UpdateInfo updateInfo)
 					}
 				}
 			} catch(Exception ex) {
-				await MesenMsgBox.ShowException(ex);
+				if(!silent) {
+					Dispatcher.UIThread.Post(() => {
+						MesenMsgBox.ShowException(ex);
+					});
+				}
 			}
 
 			return updateInfo != null ? new UpdatePromptViewModel(updateInfo) : null;