Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/copy with flag #47

Merged
merged 5 commits into from
Feb 23, 2023
Merged

F/copy with flag #47

merged 5 commits into from
Feb 23, 2023

Conversation

mellonnen
Copy link
Member

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #47 (8deae65) into develop (c3276cc) will increase coverage by 8.69%.
The diff coverage is n/a.

❗ Current head 8deae65 differs from pull request most recent head 7af990a. Consider uploading reports for the commit 7af990a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #47      +/-   ##
===========================================
+ Coverage    31.30%   40.00%   +8.69%     
===========================================
  Files            6        6              
  Lines          230      230              
===========================================
+ Hits            72       92      +20     
+ Misses         138      111      -27     
- Partials        20       27       +7     
Impacted Files Coverage Δ
portal/portal.go 36.11% <0.00%> (+36.11%) ⬆️
portal/config.go 100.00% <0.00%> (+100.00%) ⬆️

Impacted file tree graph

cmd/portal/main.go Outdated Show resolved Hide resolved
cmd/portal/send.go Outdated Show resolved Hide resolved
cmd/portal/send.go Show resolved Hide resolved
@ZinoKader
Copy link
Member

I don't think validateRendezvousAddressInViper is working anymore as it's using viper.GetString("rendezvousAddress")

@mellonnen
Copy link
Member Author

I don't think validateRendezvousAddressInViper is working anymore as it's using viper.GetString("rendezvousAddress")

a095d42

@mellonnen mellonnen merged commit 933cecf into develop Feb 23, 2023
@ZinoKader ZinoKader deleted the f/copy-with-flag branch February 26, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants