Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless semicolon #2271

Closed
wants to merge 1 commit into from
Closed

Remove useless semicolon #2271

wants to merge 1 commit into from

Conversation

RDIL
Copy link

@RDIL RDIL commented May 25, 2019

No description provided.

@dualspiral
Copy link
Contributor

Hi @RDIL,

Thanks for spotting this. While we appreciate contributions, we ask that minor changes that make no functional difference are reported to the minor issues list for that repo, in this case, that is issue #23. This ensure that our history isn't cluttered and that users can see what we have changed in the product more easily.

I also note that you targetted the bleeding branch. That branch is no longer active - our next API version will be on the api-8 branch instead and so this commit would actually have been lost when we are able to complete the implementation of Sponge for 1.14.

If this exists in stable-7, please add this as a comment to #23. If you are looking to contribute to the project, please have a read of our docs and/or come and have a chat with us on Discord.

Thanks!

@dualspiral dualspiral closed this May 25, 2019
@RDIL RDIL deleted the patch-1 branch May 25, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants