-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete recode (introduces breaking changes) #44
Conversation
Minecraft-Route is fully functional but not done! All Mojang/Minecraft Routes are not compatible with the old/current version of the API
This pull request introduces 4 alerts when merging c3cfef3 into e9af242 - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging fcdce90 into e9af242 - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging 46ea6f7 into e9af242 - view on LGTM.com new alerts:
|
* Introduce in-memory cache
+ code deduplication
Error logging to file and every request Don't log successful request in console when NODE_ENV is set to 'production'
+ Default response headers for 'Access-Control-Allow-Origin' and 'Access-Control-Allow-Headers'
Copied from https://github.com/Mc-Auth-com/Mc-Auth-Web/blob/ea01d5427ff71fe476613cc8a7ae8e8b553b08cd/README.md (to be edited later)
And make sure to use relative path correctly
const SKIN_STEVE = require('fs').readFileSync('./storage/static/steve.png'), | ||
SKIN_ALEX = require('fs').readFileSync('./storage/static/alex.png'); | ||
|
||
//FIXME: UUID '3126ba4c6uud424c877d1347fa974d23' belongs to user '_' but is not a valid UUID - API throws 500 because it detects it as invalid UUID (But should return the profile) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't find that UUID - Looks like it changed because the User _
now has d324567b-6c91-4cee-8c30-872946b5a629
But the API is fine with that and does not encounter any errors
Can be used by services like UptimeRobot to determin online status
reorganize imports
Kudos, SonarCloud Quality Gate passed!
|
Look at commit f72576d for full changelog |
A small list of changes:
*Defeat the need of my Java-Backend by processing skin images directly in the API
Planned:
Request 3d rendered versions of skinsMoved to own issue Render Skins in 3D #48