Complete recode (introduces breaking changes) #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minecraft-Route is fully functional but not done! All Mojang/Minecraft Routes are not compatible with the old/current version of the API
|
This pull request introduces 4 alerts when merging c3cfef3 into e9af242 - view on LGTM.com new alerts:
|
|
This pull request introduces 4 alerts when merging fcdce90 into e9af242 - view on LGTM.com new alerts:
|
|
This pull request introduces 4 alerts when merging 46ea6f7 into e9af242 - view on LGTM.com new alerts:
|
This was
linked to
issues
Mar 1, 2020
* Introduce in-memory cache
+ code deduplication
Error logging to file and every request Don't log successful request in console when NODE_ENV is set to 'production'
SpraxDev
changed the title
+ Default response headers for 'Access-Control-Allow-Origin' and 'Access-Control-Allow-Headers'
Copied from https://github.com/Mc-Auth-com/Mc-Auth-Web/blob/ea01d5427ff71fe476613cc8a7ae8e8b553b08cd/README.md (to be edited later)
And make sure to use relative path correctly
SpraxDev
commented
Mar 3, 2020
| const SKIN_STEVE = require('fs').readFileSync('./storage/static/steve.png'), | ||
| SKIN_ALEX = require('fs').readFileSync('./storage/static/alex.png'); | ||
|
|
||
| //FIXME: UUID '3126ba4c6uud424c877d1347fa974d23' belongs to user '_' but is not a valid UUID - API throws 500 because it detects it as invalid UUID (But should return the profile) |
There was a problem hiding this comment.
Can't find that UUID - Looks like it changed because the User _ now has d324567b-6c91-4cee-8c30-872946b5a629
But the API is fine with that and does not encounter any errors
Can be used by services like UptimeRobot to determin online status
reorganize imports
|
Kudos, SonarCloud Quality Gate passed!
|
|
Look at commit f72576d for full changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small list of changes:
*Defeat the need of my Java-Backend by processing skin images directly in the API
Planned:
Request 3d rendered versions of skinsMoved to own issue Render Skins in 3D #48