Fix conversion when COMPAT_MODE is set #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conversion was just backwards. In COMPAT_MODE, period value of 1000 corresponds to 1kHz, while, without COMPAT_MODE, 5000 corresponds to the same period. So when SDK_PWM_PERIOD_COMPAT_MODE is set, period should be multiplied by 5. For the same reason, duty needs to be divided by 5.
perpernorbi
added a commit
to perpernorbi/Sming
that referenced
this pull request
Aug 24, 2018
Conversions in pwm.c are bugous. Fix is already available for the original repository, but the merge request has not yet been accepted. See StefanBruens/ESP8266_new_pwm#26 for details.
slaff
pushed a commit
to SmingHub/Sming
that referenced
this pull request
Aug 28, 2018
* Fix duty and period conversion in pwm.c Conversions in pwm.c are bugous. Fix is already available for the original repository, but the merge request has not yet been accepted. See StefanBruens/ESP8266_new_pwm#26 for details. * Create macro to calculate max duty * Remove hard-coded maximum duty Class HardwarePWM actually provides a function to query the maximum value of duty. * Fix comment ENABLE_CUSTOM_PWM defaults to 1 since d870c27.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conversion was just backwards. In COMPAT_MODE, period value of 1000
corresponds to 1kHz, while, without COMPAT_MODE, 5000 corresponds to
the same period. So when SDK_PWM_PERIOD_COMPAT_MODE is set, period
should be multiplied by 5. For the same reason, duty needs to be
divided by 5.