Skip to content

Commit

Permalink
fix: broken tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Stephen-RA-King committed Sep 22, 2022
1 parent c48bf34 commit 7fa6191
Showing 1 changed file with 5 additions and 12 deletions.
17 changes: 5 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
[![DeepSource][deepsource-image]][deepsource-url]
[![license][license-image]][license-url]

[**pip-tools**][pip-tools-url] and [**Pre-Commit**][pre-commit-url] are two of my favourite development tools. However, they don't necessarily agree
[**pip-tools**][pip-tools-url] and [**Pre-Commit**][pre-commit-url] are two of my favourite development tools. However, they don't always necessarily agree
on what versions of packages should be installed.
This lack of consolidation can lead to problems with pre-commit.
This pre-commit plugin syncs the pre-commit package versions with the versions generated by pip-tools' compile process.
Expand All @@ -47,8 +47,8 @@ There was however no problem manually running flake8 from the command line. Upon
incompatibility issue with one of its plugins.
With further investigation I noticed that pip-tools had pinned flake8 to an earlier version to what pre-commit was caching.

In short - pip-tools does a spectacularly good job pinning packages and package dependencies. It has one job to do and it does it very well. The pre-commit autoupdate command just updates the "rev" for the "repo" in the
.pre-commit-config.yaml file.
In short - pip-tools does a spectacularly good job pinning your dependencies and the dependencies of these dependencies. It has one job to do and it does it perfectly.
The pre-commit autoupdate command just updates the "rev" for the "repo" in the .pre-commit-config.yaml file to the latest version available and ignores the dependencies.

The following example displays the way flake8 and a few plugins are configured by the two tools :

Expand Down Expand Up @@ -189,15 +189,8 @@ _For more examples and usage, please refer to the [Wiki][wiki]._
---

- Move some global variables into a separate settings file (toml).
- Settings configurable from the command line.
- Improve web request performance with aiohttp library.
- increase indentation on yaml write.

## Known Issues

---

- Fix failing tests
- Settings configurable from the command line (and therefore configurable from the pre-commit.yaml file).
- Improve web request performance with asyncio / aiohttp libraries.

## Meta

Expand Down

0 comments on commit 7fa6191

Please sign in to comment.