Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate skill files to german #19

Merged
merged 12 commits into from
Dec 23, 2021
Merged

Translate skill files to german #19

merged 12 commits into from
Dec 23, 2021

Conversation

MidnightNerd
Copy link
Contributor

No description provided.

Copy link
Owner

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I tested a bit with the little knowledge I have of German language and these translations seem to work pretty well.

In order to make German available in the app you need to edit the app/src/main/res/values/arrays.xml file and add <item>Deutsch</item> under the array pref_language_entries and <item>de</item> under the array pref_language_entry_values. Make sure to keep the order of the languages the same in both arrays. If you feel uncomfortable doing this feel free to delegate it to me ;-)

Btw I built an APK with your work included, if you want to try it out: app-debug.zip

app/src/main/sentences/de/search.dslf Outdated Show resolved Hide resolved
app/src/main/sentences/de/weather.dslf Outdated Show resolved Hide resolved
app/src/main/sentences/de/open.dslf Outdated Show resolved Hide resolved
app/src/main/sentences/de/calculator.dslf Outdated Show resolved Hide resolved
@@ -0,0 +1,10 @@
calculator: medium
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the calculator will not be available since dicio-numbers has not been translated to German yet. This is not blocking, though, as German can be made available in the app even if the calculator won't be enabled.

@MidnightNerd
Copy link
Contributor Author

Thanks for your fast reply and for the app build. It made it really easy to improve the files a bit.

@Stypox
Copy link
Owner

Stypox commented Dec 23, 2021

Thank you! :-D

@Stypox Stypox merged commit ac83901 into Stypox:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants