Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache rq binary #820

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Cache rq binary #820

merged 3 commits into from
Jun 10, 2024

Conversation

charlieegan3
Copy link
Member

@charlieegan3 charlieegan3 commented Jun 10, 2024

Fixes #818

Copy link
Member

@anderseknert anderseknert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was fast! LGTM, but I suspect the which command is redundant?

.github/workflows/build.yaml Outdated Show resolved Hide resolved
uses: actions/cache@v3
with:
path: ~/go/bin/rq
key: ${{ runner.os }}-${{ runner.arch }}-go-rq
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth adding a version? I guess we can worry about that when there's an rq version we want and it's not getting here because of the cache 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... I did wonder about that. Added now.

Copy link
Member

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: Charlie Egan <[email protected]>
Signed-off-by: Charlie Egan <[email protected]>
@charlieegan3
Copy link
Member Author

Screenshot 2024-06-10 at 15 08 13

I am seeing this working now on this PR.

Signed-off-by: Charlie Egan <[email protected]>
@charlieegan3 charlieegan3 merged commit b6588dc into StyraInc:main Jun 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: See if we can use caching to avoid downloading rq over and over
3 participants