Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't suggest if or contains following import #834

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Don't suggest if or contains following import #834

merged 1 commit into from
Jun 13, 2024

Conversation

anderseknert
Copy link
Member

Also:

  • improve handling of manually invoked suggestions
  • don't suggest "import" after "import "

Fixes #830

charlieegan3
charlieegan3 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@charlieegan3 charlieegan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this, looks good!

@anderseknert
Don't suggest if or contains following import
64258ac 
Also:
- improve handling of manually invoked suggestions
- don't suggest "import" after "import "

Fixes #830

Signed-off-by: Anders Eknert <[email protected]>
@anderseknert anderseknert merged commit 3af7d06 into main Jun 13, 2024
3 checks passed
@anderseknert anderseknert deleted the if-contains-fix-completion branch June 13, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlieegan3 charlieegan3 charlieegan3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Completions: if and contains should not be suggested following import
2 participants
@anderseknert @charlieegan3