Clear the store when reloading config #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also ensures that config is loaded before doing the initial load of the workspace. This ensure that loaded ignored files do not need to then be immediately dropped. Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
force-pushed
the
clear-store
branch
from
320daf2
to
0c23535
Compare
uri should be fileURI everywhere in the project to avoid conflicts. Signed-off-by: Charlie Egan <[email protected]>
Signed-off-by: Charlie Egan <[email protected]>
Fixes StyraInc#832 Signed-off-by: Charlie Egan <[email protected]>
Fixes StyraInc#843 This is rudimentary, but have put the tools in place to have providers return more information about the items. We already have mandatory but we might want to roll this into some ranking system in future. Signed-off-by: Charlie Egan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also ensures that config is loaded before doing the initial load of the workspace. This means that loaded ignored files do not need to then be immediately dropped.
Also
Fixes #832
Fixes #843