More Rego completion providers #858
Conversation
Rules converted: - `commonrule` - `package` - `rego.v1` Also: - move some common functions into utility package. - add `Name()` to provider interface to be able to easily measure performance impact of a named provider Signed-off-by: Anders Eknert <[email protected]>
|
|
||
| suggested_names := { | ||
| "allow", | ||
| "authorized", |
There was a problem hiding this comment.
This is new... I personally would not be keen for authorized appearing at the start of every line but that might just be me. I would consider result a better third candidate, but would stick to allow deny myself.
There was a problem hiding this comment.
I like result, as well as report (that we use in Regal) and a few others. allow is fine but deny is IMHO legacy since contains was made a requirement. How does a deny "contain" anything? It just doesn't read right to me. But either way, I'm more keen to add things than to have them removed. These are just suggestions anyway.
There was a problem hiding this comment.
yeah fair enough, I'd never thought about deny like that...
There was a problem hiding this comment.
"report contains ..." :chefs-kiss:
Rules converted:
commonrulepackagerego.v1Also:
Name()to provider interface to be able to easily measure performance impact of a named provider