Completions: package name now suggested from any path component #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And fix bug that would sometimes suggest "" as the package name. Oh, and the provider is now written in Rego :) Fixes #846 Fixes #856 Signed-off-by: Anders Eknert <[email protected]>
anderseknert
force-pushed
the
packagename-rego
branch
from
a39339d
to
dd12978
Compare
srenatus
approved these changes
Jun 24, 2024
|
|
||
| abs_dir := base(input.regal.file.name) | ||
| rel_dir := trim_prefix(abs_dir, input.regal.context.workspace_root) | ||
| fix_dir := replace(replace(trim_prefix(rel_dir, ps), ".", "_"), ps, ".") |
There was a problem hiding this comment.
heh, yeah, not sure how that could be made more clear... perhaps an extra intermediate assignment or something
That's correct. We should have some general way of rewriting refs to account for that. I was hoping someone would just fix that "keywords in refs need quoting" in OPA first, so we'd at least have one less thing to handle here 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix bug that would sometimes suggest "" as the package name.
Oh, and the provider is now written in Rego :)
Fixes #846
Fixes #856