Add snippets provider #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snippets are special inserts that allow users to enter values and press tab to move to the next location. https://code.visualstudio.com/docs/editor/userdefinedsnippets Add snippets for: - `some v in coll`, - `some k, v in coll` - `every v in coll` - `every k, v in coll` Got interested in trying this after learniung that Zed supports snippets in the latest release. I've tried and confirmed this works in both VS Code and in Zed. Signed-off-by: Anders Eknert <[email protected]>
srenatus
approved these changes
Jun 25, 2024
|
Nice how little code is needed to add this 👍 |
| "kind": 15, | ||
| "label": "some key-value iteration (snippet)", | ||
| "textEdit": { | ||
| "newText": "some ${1:key}, ${2:value} in ${3:collection}\n$0", |
There was a problem hiding this comment.
Didn't realise this was so simple, we might want to update things like package completions to use the same format.
There was a problem hiding this comment.
Totally! This should be trivial to extend with more cases. I just wanted to start from somewhere.
There was a problem hiding this comment.
We could also do things like more advanced function calls (http.send et. al.). where we pre-fill some example values. Like how the VS Code docs have an example where they do this for some AJAX call.
charlieegan3
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snippets are special inserts that allow users to enter values and press tab to move to the next location.
Untitled.mov
https://code.visualstudio.com/docs/editor/userdefinedsnippets
Add snippets for:
some v in coll,some k, v in collevery v in collevery k, v in collGot interested in trying this after learning that Zed supports snippets in the latest release. I've tried and confirmed this works in both VS Code and in Zed.