Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token permissions #886

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Fix token permissions #886

merged 1 commit into from
Jul 2, 2024

Conversation

anderseknert
Copy link
Member

Use read-all at the top level. Not sure if we actually need anything more somewhere, but I guess this is one way to find out.

Use `read-all` at the top level. Not sure if we actually need anything more
somewhere, but I guess this is one way to find out.

Signed-off-by: Anders Eknert <[email protected]>
@srenatus
Copy link
Member

srenatus commented Jul 2, 2024

I'd expect that release creation through goreleaser might need more. But let's find out? 🤔

@anderseknert anderseknert merged commit a4c96a4 into main Jul 2, 2024
3 checks passed
@anderseknert anderseknert deleted the permissions branch July 2, 2024 08:18
@anderseknert
Copy link
Member Author

@srenatus yeah, will push a release this week, so shouldn’t have forgotten about it by then :)

@charlieegan3
Copy link
Member

FWIW, I added 34202b5 and 31bee8d to set the permissions to:

permissions:
   # this is needed to create a release
   contents: write
   # this is needed to create artifacts in ghcr
   packages: write

based on the details here: https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

I'd not have worked this out without trial and error I think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants