Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Darkmode Support #130

Open
wants to merge 21 commits into
base: canary
Choose a base branch
from
Open

Add Darkmode Support #130

wants to merge 21 commits into from

Conversation

EdisonJwa
Copy link

@EdisonJwa EdisonJwa commented Mar 1, 2020

Contributing rules

  • Fork the repo and create your branch from canary. Then be sure to put the canary branch as the target for your pull request.
  • Please be sure to follow the contributing guidelines, especially for commit message.
  • Remove the Contributing rules part from this description if you like.
  • Fill out the other parts from this description.

If you don't do so, we might change your pull request's title and using squash to merge your changed.

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / new features).
  • Docs have been added / updated (for bug fixes / new features).

What kind of change does this PR introduce? (check with "x")

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Description

Add Darkmode support
Demo: https://www.wevg.org


Verification steps

@Misaka13514
Copy link

Misaka13514 commented Apr 13, 2020

我原来也想自己改个darkmode的
改的差不多了才发现这个pr改的比我早还改的比我好
👍 :)
darkmode颜色选取上是否需要再讨论一下?
mac这边看来的话demo要比其他darkmode的界面(如Finder/Chrome)暗了些
苏卡卡的blog要跟进下加一个favicon-dark吗ww

@EdisonJwa
Copy link
Author

@Misaka13514 颜色选取如果有更好的提议当然好

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants