-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrap metrics from pods basing on annotations #852
Conversation
d04fa83
to
add4462
Compare
4bd7e23
to
fc8bd4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! Left just one nit comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d1ab938
to
a062701
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find!
* Update additional_prometheus_configuration.md Co-authored-by: Sam Song <[email protected]>
4db8bd1
to
3643982
Compare
Description
Scrap metrics from pods basing on annotations
rel: prometheus-operator/kube-prometheus#16 (comment)
rel: prometheus/prometheus#4131
Testing performed