Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documented python version support; add py3.9 test configuration #122

Merged
merged 4 commits into from
Oct 28, 2021

Conversation

kandersolar
Copy link
Contributor

I noticed a few places in the docs that mentioned older python versions that are no longer supported as of #112 and updated them here. I think the PyPI badge in the readme will automatically update once the changes to setup.py are propagated to pypi.org. I also added a python 3.9 test configuration.

I assume the tests will fail because of the same sphinx issue in #121 so I'm marking this as draft and will merge master in after #121 is complete :)

Side notes:

  1. Looks like the docs on gh-pages are still for 1.5.0 and could use a rebuild for 1.5.1
  2. I don't think this is a pressing issue (though I have almost no experience w/ CircleCI so maybe I'm wrong), just FYI: the docker images used in pvfactor's CI config are apparently considered "legacy" and these new images should be preferred: https://circleci.com/developer/images/image/cimg/python

@kandersolar kandersolar marked this pull request as ready for review October 12, 2021 21:14
@kandersolar
Copy link
Contributor Author

Okay @campanelli-sunpower @anomam I think this is ready. The 3.7 job is still building pandas from source; I did not investigate why. Python 3.10.0 was released recently, but not all of the core pydata packages have released 3.10 wheels yet (matplotlib, maybe others), so I did not add a 3.10 job here, but probably it should be added at some point before too long.

Thanks!

@campanelli-sunpower
Copy link
Contributor

@kanderso-nrel I updated the documentation to v1.5.1 at https://sunpower.github.io/pvfactors/, and I should have a small PR coming for your review to fix some documentation issues that I discovered along the way, which should go in before we release this. Also, I'd like to fix the docker image issue you spotted, as well as automate documentation builds and deploys on each tag, but I won't hold up the release if that CI work ends up taking more time than I have now.

I should be reviewing this PR shortly.

Copy link
Contributor

@campanelli-sunpower campanelli-sunpower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that 3.9 tests are passing in CI with same count as 3.8 tests. Thanks for the updates @kanderso-nrel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants