Fix assertion failure in triangle drawing on the SDL backend. #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed by changing the type of an edge from Rectf to std::pair<Vector, Vector>. This assertion was introduced in SuperTux@fa31cab (and if this causes more issues, we may want to retract this assertion or turn it into a debug print for now). Shouldn't affect optimized builds as asserts normally are off when optimizing via -DNDEBUG.
tobbi
added
category:code
status:needs-review
mrkubax10
removed
the
status:needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed by changing the type of an edge from Rectf to std::pair<Vector, Vector>.
This assertion was introduced in
fa31cab
(and if this causes more issues, we may want to retract this assertion
or turn it into a debug print for now).
Shouldn't affect optimized builds as asserts normally are off when
optimizing via -DNDEBUG.