-
-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout widget in editor is now scrollable #1528
Conversation
Awesome, especially for the forest worldmap, since it has so many tilesets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I would block it from further scrolling if there's only one icon left on the screen. Currently you can flush them all to the left.
Btw, I expected mouse scrolling, by the title, maybe I expected too much 😆.
Approval from me once the review comments were addressed. |
Oh, and check the travis warnings and fix them. |
I'm gonna fix all of this, I'd just have one question :
I'm not sure to understand... It scrolls by hovering the first or last 32 pixels of the widget bar, isn't that the way it should work? I wanted to make it work the same way as the tilesets widget. Do you want me to make it another way? What's the method you originally understood from the title? |
Sorry, my comment didn't make much sense. What I had in mind was mouse wheel scrolling, just like the tile selection panel does, but horizontally. |
Oh, okay. Should I also make it scrollable with mouse wheel? |
If it isn't much of a deal for you then sure. |
I'll look into this; I'm pushing my first fix batch in a few moments, I'll use that first batch to see if there are any other Travis errors. I'll add the mouse wheel scroll (if doable in less than an hour 😆) in the second next commit, along with any other Travis errors if applicable. |
Alright, I couldn't resist and I did everything in a single commit. I do have a problem, though; scrolling with the mouse wheel also triggers the editor behind the widget. It seems like my |
Nevermind, it's a code 18. It works fine now, and I fixed all the requested changes; I'll commit now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an unintended behaviour in that new feature, the bar keeps scrolling, even when I take the mouse.
See video:
https://youtu.be/BV5S4DYmnbU
Having dozens of tilemaps and other sector elements is no longer a pain to manage - now you can scroll the toolbar and access those sneaky little icons!