Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't spawn Tux in the ground #1575

Merged
merged 1 commit into from Nov 18, 2020
Merged

don't spawn Tux in the ground #1575

merged 1 commit into from Nov 18, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 9, 2020

When returning to the main screen from a world, this warning would appear:

[WARNING] src/supertux/sector.cpp:231 [levels/misc/menu.stl] Tried spawning Tux in solid matter. Compensating.

Since Tux is always "small" in this level, this code is triggered, which pushes Tux into the ground. By moving the spawnpoint up to match other levels, it pushes Tux to the expected position.

if (!player.is_big()) {
player.move(player_pos + Vector(0,32));

@ghost ghost mentioned this pull request Nov 9, 2020
@Semphriss
Copy link
Member

Semphriss commented Nov 9, 2020

I'm not sure I understand - how does moving the player to the right fix a vertical-based bug?

EDIT: I retract my comment, I saw the explanation in the linked issue.

@papb
Copy link

papb commented Nov 9, 2020

So this PR closes #240?

@ghost
Copy link
Author

ghost commented Nov 9, 2020

So this PR closes #240?

No, it only fixes one instance of this.

@Zwatotem Zwatotem merged commit 18873bc into SuperTux:master Nov 18, 2020
@ghost ghost deleted the patch-1 branch November 18, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants