Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing (or rather, not loading) editor sprite actions #2590

Merged
merged 7 commits into from
Aug 19, 2023

Conversation

Narre
Copy link
Contributor

@Narre Narre commented Aug 18, 2023

Right now, some badguys in the editor show the wrong sprite action (mostly for Direction::AUTO, but fish with "swim" actions for all directions). There was also a bug that the editor checked m_dir instead of m_start_dir for the badguys with Direction::AUTO. (m_dir is the current direction when the level is running, m_start_dir is the direction saved in the .stl level file that the enemy starts in).
Some would show facing in the wrong direction, some would show the wrong sprite action (eg. woken up sleeping spiky instead of sleeping, burning toads, etc.)

This PR fixes that.

@mrkubax10 mrkubax10 added involves:editor category:code status:needs-review Work needs to be reviewed by other people type:bugfix Pull Requests that fix bugs. labels Aug 18, 2023
src/badguy/badguy.cpp Outdated Show resolved Hide resolved
@Narre Narre requested a review from tobbi August 19, 2023 13:21
src/badguy/badguy.cpp Outdated Show resolved Hide resolved
src/badguy/badguy.cpp Outdated Show resolved Hide resolved
@tobbi tobbi self-requested a review August 19, 2023 14:02
@mrkubax10 mrkubax10 merged commit 1ffe32d into SuperTux:master Aug 19, 2023
@mrkubax10 mrkubax10 removed the status:needs-review Work needs to be reviewed by other people label Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants