Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more convenience functions to Player class #3037

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

tobbi
Copy link
Member

@tobbi tobbi commented Aug 7, 2024

Waddup, biatches! I just added a few convenience methods to the player class that will reduce some complexity in if statements elsewhere.

Have fun "reviewing" (aka tearing into my code changes).

This reduces some code complexity in if statements
@MatusGuy
Copy link
Member

MatusGuy commented Aug 7, 2024

no

@tobbi
Copy link
Member Author

tobbi commented Aug 9, 2024

Thank you, @MatusGuy for your enthusiasm in reviewing the PR.

@mrkubax10
Copy link
Member

I agree with Tobbi, could you try being a little bit nicer?

@tobbi
Copy link
Member Author

tobbi commented Aug 9, 2024

It's an ongoing feud at this point. TBH, I don't know how serious either of us are about this. I just know that I'm more on edge / unhinged than usual.

Copy link
Member

@MatusGuy MatusGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Tobbi, could you try being a little bit nicer?

I don't think his attitude was correct either. By saying "no", I was joking around, like he was in his PR description.

Anyway, I hope we can put that aside.

src/object/player.hpp Outdated Show resolved Hide resolved
@tobbi
Copy link
Member Author

tobbi commented Aug 15, 2024

I agree with Tobbi, could you try being a little bit nicer?

I don't think his attitude was correct either. By saying "no", I was joking around, like he was in his PR description.

Anyway, I hope we can put that aside.

It was quite clear from the start that we were both joking, that's why I edited your message to a very polite one, before you added it back. No worries. This is all fine, unlike some other things I could tell you about.

Copy link
Member

@bruhmoent bruhmoent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested.

@MatusGuy MatusGuy merged commit aee3fc7 into master Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants