-
-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more convenience functions to Player class #3037
Conversation
This reduces some code complexity in if statements
no |
Thank you, @MatusGuy for your enthusiasm in reviewing the PR. |
I agree with Tobbi, could you try being a little bit nicer? |
It's an ongoing feud at this point. TBH, I don't know how serious either of us are about this. I just know that I'm more on edge / unhinged than usual. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Tobbi, could you try being a little bit nicer?
I don't think his attitude was correct either. By saying "no", I was joking around, like he was in his PR description.
Anyway, I hope we can put that aside.
[ci skip] Co-authored-by: Marty <[email protected]>
It was quite clear from the start that we were both joking, that's why I edited your message to a very polite one, before you added it back. No worries. This is all fine, unlike some other things I could tell you about. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested.
Waddup, biatches! I just added a few convenience methods to the player class that will reduce some complexity in if statements elsewhere.
Have fun "reviewing" (aka tearing into my code changes).