Fix slow sync when using IR or wall remote #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable fastSync mode to speed up settings and status sync time by 2x.
Merge with origin repo
|
Your code formatting doesn't match the existing formatting; you should fix that before asking to merge. This repo uses K&R style. |
sethkinast
reviewed
Feb 19, 2024
src/HeatPump.cpp
Outdated
| return wantedSettings; | ||
| } | ||
|
|
||
| unsigned long HeatPump::getLastWanted() |
There was a problem hiding this comment.
You can check it here in my project: https://github.com/dzungpv/mitsubishi2MQTT/blob/9c2bcdda142fff1290fbef9550f4f9214b3f510f/main/main.cpp#L2051. Code have been run on esp8266 to 60 days without any reboot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change and enable fast sync, time sync speed up by 2x.
Expose wantedSettings and lastWanted make mqtt control over Home Assistant more stable, see: https://github.com/dzungpv/mitsubishi2MQTT