chore(utils): Ensure consistent declaration style of utility function…

…s and standardize parameters for the sleep method (#7554) * refactor: Changed parameter names to match those in other sleep utility functions. * refactor: Most utility functions are defined as regular functions, updated this one to match. * fix: formatting
TanStack · Jul 17, 2024 · 95d814a · 95d814a
1 parent eb21d1e
commit 95d814a
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 12 deletions.
diff --git a/packages/query-core/src/__tests__/utils.ts b/packages/query-core/src/__tests__/utils.ts
@@ -32,11 +32,11 @@ export function sleep(timeout: number): Promise<void> {
   })
 }
 
-export const executeMutation = <TVariables>(
+export function executeMutation<TVariables>(
   queryClient: QueryClient,
   options: MutationOptions<any, any, TVariables, any>,
   variables: TVariables,
-) => {
+) {
   return queryClient
     .getMutationCache()
     .build(queryClient, options)

diff --git a/packages/query-core/src/utils.ts b/packages/query-core/src/utils.ts
@@ -340,9 +340,9 @@ function hasObjectPrototype(o: any): boolean {
   return Object.prototype.toString.call(o) === '[object Object]'
 }
 
-export function sleep(ms: number): Promise<void> {
+export function sleep(timeout: number): Promise<void> {
   return new Promise((resolve) => {
-    setTimeout(resolve, ms)
+    setTimeout(resolve, timeout)
   })
 }
 
@@ -378,7 +378,7 @@ export function addToStart<T>(items: Array<T>, item: T, max = 0): Array<T> {
 export const skipToken = Symbol()
 export type SkipToken = typeof skipToken
 
-export const ensureQueryFn = <
+export function ensureQueryFn<
   TQueryFnData = unknown,
   TQueryKey extends QueryKey = QueryKey,
 >(
@@ -387,7 +387,7 @@ export const ensureQueryFn = <
     queryHash?: string
   },
   fetchOptions?: FetchOptions<TQueryFnData>,
-): QueryFunction<TQueryFnData, TQueryKey> => {
+): QueryFunction<TQueryFnData, TQueryKey> {
   if (process.env.NODE_ENV !== 'production') {
     if (options.queryFn === skipToken) {
       console.error(

diff --git a/packages/query-persist-client-core/src/__tests__/utils.ts b/packages/query-persist-client-core/src/__tests__/utils.ts
@@ -13,7 +13,7 @@ export function sleep(timeout: number): Promise<void> {
   })
 }
 
-export const createMockPersister = (): Persister => {
+export function createMockPersister(): Persister {
   let storedState: PersistedClient | undefined
 
   return {
@@ -30,7 +30,7 @@ export const createMockPersister = (): Persister => {
   }
 }
 
-export const createSpyPersister = (): Persister => {
+export function createSpyPersister(): Persister {
   return {
     persistClient: vi.fn(),
     restoreClient: vi.fn(),

diff --git a/packages/react-query/src/__tests__/utils.tsx b/packages/react-query/src/__tests__/utils.tsx
@@ -22,13 +22,13 @@ export function renderWithClient(
   } as any
 }
 
-export const Blink = ({
+export function Blink({
   duration,
   children,
 }: {
   duration: number
   children: React.ReactNode
-}) => {
+}) {
   const [shouldShow, setShouldShow] = React.useState<boolean>(true)
 
   React.useEffect(() => {

diff --git a/packages/solid-query/src/__tests__/utils.tsx b/packages/solid-query/src/__tests__/utils.tsx
@@ -12,11 +12,11 @@ export function queryKey() {
   return [`query_${queryKeyCount}`]
 }
 
-export const Blink = (
+export function Blink(
   props: {
     duration: number
   } & ParentProps,
-) => {
+) {
   const [shouldShow, setShouldShow] = createSignal<boolean>(true)
 
   createEffect(() => {