Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Streaming with Server Components docs to reflect correct usage #7725

Merged
merged 6 commits into from
Jul 17, 2024

Conversation

Aerilym
Copy link
Contributor

@Aerilym Aerilym commented Jul 11, 2024

Streaming with Server Components has a minor issue with its usage example.

  • Showed and explained the move of the getQueryClient function from the gloabal/providers.tsx file to its own file.
  • Added missing imports.
  • Replaced new QueryClient() with getQueryClient() to make use of the client with serialize and deserialize.
    The code block prior (app/get-query-client.ts) is used to add serialize and deserialize, I imagine the intent was to use that query client in the server component.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 11, 2024
Copy link

nx-cloud bot commented Jul 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 84c014c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Jul 15, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 84c014c

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7725

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@7725

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@7725

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@7725

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7725

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@7725

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@7725

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@7725

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@7725

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@7725

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@7725

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@7725

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@7725

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@7725

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@7725

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@7725

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@7725

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@7725

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@7725

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@7725

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@7725


templates

@TkDodo
Copy link
Collaborator

TkDodo commented Jul 15, 2024

please fix formatting

@Aerilym
Copy link
Contributor Author

Aerilym commented Jul 15, 2024

Sorry about that, I've run prettier so the formatting should be all good now

@TkDodo TkDodo merged commit a1ce3c4 into TanStack:main Jul 17, 2024
3 checks passed
@Aerilym Aerilym deleted the patch-1 branch August 12, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants