Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): type config names #7766

Merged
merged 2 commits into from
Jul 20, 2024
Merged

fix(eslint-plugin): type config names #7766

merged 2 commits into from
Jul 20, 2024

Conversation

AhmedBaset
Copy link
Contributor

When configuring the eslint plugin with // @ts-check at the top of eslint.config.js there is no suggestions for config names because it's of type string

// @ts-check
import query from "@tanstack/eslint-plugin-query";

export default defineConfig(
  query.config.whateverConfigName, // no completion or type checking
)

This PR fixes

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 20, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 36aeb8b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 36aeb8b

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7766

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@7766

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@7766

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@7766

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7766

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@7766

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@7766

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@7766

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@7766

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@7766

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@7766

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@7766

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@7766

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@7766

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@7766

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@7766

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@7766

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@7766

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@7766

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@7766

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@7766

templates

@codecov Codecov
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.00%. Comparing base (e4e65be) to head (36aeb8b).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #7766       +/-   ##
===========================================
+ Coverage   44.64%   84.00%   +39.35%     
===========================================
  Files         185       11      -174     
  Lines        7078      350     -6728     
  Branches     1566      129     -1437     
===========================================
- Hits         3160      294     -2866     
+ Misses       3555       42     -3513     
+ Partials      363       14      -349
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query 84.00% <ø> (ø)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@lachlancollins lachlancollins merged commit 404c2fa into TanStack:main Jul 20, 2024
8 checks passed
@AhmedBaset AhmedBaset deleted the eslint-typed-config branch July 20, 2024 11:18
@favna favna mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lachlancollins lachlancollins lachlancollins approved these changes

Assignees
No one assigned
Labels
package: eslint-plugin-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AhmedBaset @lachlancollins