Skip to content

Commit

Permalink
Fix internal Linter warnings #trivial (#340)
Browse files Browse the repository at this point in the history
* Fix internal Linter warnings

* Remove explicit copy for block as let us just use the default one
  • Loading branch information
maicki authored and garrettmoon committed Jun 8, 2017
1 parent 786ac15 commit 13c467b
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion Source/ASDisplayNode+Subclasses.h
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ NS_ASSUME_NONNULL_BEGIN
*
* @warning Subclasses must not override this; it returns the last cached layout and is never expensive.
*/
@property (nullable, nonatomic, readonly, assign) ASLayout *calculatedLayout;
@property (nullable, nonatomic, readonly, strong) ASLayout *calculatedLayout;

#pragma mark - View Lifecycle
/** @name View Lifecycle */
Expand Down
4 changes: 2 additions & 2 deletions Source/ASDisplayNode.h
Original file line number Diff line number Diff line change
Expand Up @@ -646,12 +646,12 @@ extern NSInteger const ASDefaultDrawingPriority;
#if TARGET_OS_IOS
@property (nonatomic, assign, getter=isExclusiveTouch) BOOL exclusiveTouch; // default=NO
#endif
@property (nonatomic, assign, nullable) CGColorRef shadowColor; // default=opaque rgb black
@property (nonatomic, nullable) CGColorRef shadowColor; // default=opaque rgb black
@property (nonatomic, assign) CGFloat shadowOpacity; // default=0.0
@property (nonatomic, assign) CGSize shadowOffset; // default=(0, -3)
@property (nonatomic, assign) CGFloat shadowRadius; // default=3
@property (nonatomic, assign) CGFloat borderWidth; // default=0
@property (nonatomic, assign, nullable) CGColorRef borderColor; // default=opaque rgb black
@property (nonatomic, nullable) CGColorRef borderColor; // default=opaque rgb black

// UIResponder methods
// By default these fall through to the underlying view, but can be overridden.
Expand Down
4 changes: 2 additions & 2 deletions Source/Details/ASImageProtocols.h
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ withDownloadIdentifier:(id)downloadIdentifier;
/**
@abstract A block which receives the cover image. Should be called when the objects cover image is ready.
*/
@property (nonatomic, strong, readwrite) void (^coverImageReadyCallback)(UIImage *coverImage);
@property (nonatomic, readwrite) void (^coverImageReadyCallback)(UIImage *coverImage);

/**
@abstract Returns whether the supplied data contains a supported animated image format.
Expand Down Expand Up @@ -209,7 +209,7 @@ withDownloadIdentifier:(id)downloadIdentifier;
/**
@abstract Should be called when playback is ready.
*/
@property (nonatomic, strong, readwrite) dispatch_block_t playbackReadyCallback;
@property (nonatomic, readwrite) dispatch_block_t playbackReadyCallback;

/**
@abstract Return the image at a given index.
Expand Down
2 changes: 1 addition & 1 deletion Source/Layout/ASLayoutElement.h
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ typedef NS_ENUM(NSUInteger, ASLayoutElementType) {
/**
* @abstract A size constraint that should apply to this ASLayoutElement.
*/
@property (nonatomic, assign, readonly) ASLayoutElementStyle *style;
@property (nonatomic, strong, readonly) ASLayoutElementStyle *style;

/**
* @abstract Returns all children of an object which class conforms to the ASLayoutElement protocol
Expand Down

0 comments on commit 13c467b

Please sign in to comment.