Skip to content

Commit

Permalink
Update Danger workflow (#1636)
Browse files Browse the repository at this point in the history
Turned out that @babel/plugin-transform-flow-strip-types is needed for TypeScript/Bale transpilation with we don't need because we use JS. So instead of installing the module, we can. just disable transpilation by DANGER_DISABLE_TRANSPILATION environment variable to true.

Test plan: Tested manually here: https://github.com/TextureGroup/Texture/commit/a4cfe347914c23aafe08603bf82372d4cb94136c/checks
  • Loading branch information
nguyenhuy committed Aug 22, 2019
1 parent 44aecb3 commit 28be9bb
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/danger.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ jobs:
steps:
- name: Checkout the Git repository
uses: actions/checkout@v1
# Danger JS would fail because of the below missing module.
# TODO: Report to Danger JS
- name: Install missing module
run: yarn add -D @babel/plugin-transform-flow-strip-types
# TODO: Figure out why GITHUB_TOKEN isn't enough for Danger JS to create a comment.
# Our dangerfile.js escalates any warnings as failures to get more attention.
#
Expand All @@ -29,3 +25,4 @@ jobs:
uses: danger/[email protected]
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
DANGER_DISABLE_TRANSPILATION: true

0 comments on commit 28be9bb

Please sign in to comment.